Large Png's are not fully written to the file sometimes.

Open startswithaj opened this issue 2 years ago • 3 comments

Thanks for producing this @naddison36

When I generate a large diagram and output to a png. It seems like the whole image is not getting written to the file. Ends up with a partial image. It's intermittent, it doesn't always happen. Seems like it could be a race condition between the file being written and the program exiting. Maybe the file write isn't being awaited? Screenshot 2023-05-04 at 4 05 36 pm

May 04 '23 06:05 startswithaj

Thanks for reporting. Is there an example contract this sometimes happens for?

May 04 '23 06:05 naddison36

hey @naddison36 its a private repo that I'm working on. I can have a look for a public repo thats big and try and repro.

May 04 '23 06:05 startswithaj

Had a quick look at the code that writes the file. Looks tight. It could be the fault of convert-svg-to-png

May 04 '23 06:05 startswithaj