react-datasheet
react-datasheet copied to clipboard
PropTypes settings: func vs class
Hi,
I'm getting a warning that my react component passed to the valueViewer setting is not a func.
Warning: Failed prop type: Invalid prop `valueViewer` of type `object` supplied to `DataCell`, expected `function`.
See below: this is because valueViewer has the propType set to func (along with other props). Should this be expanded to encompass react classes as well (i.e. any react component)?
DataSheet.propTypes = {
data: PropTypes.array.isRequired,
className: PropTypes.string,
overflow: PropTypes.oneOf(['wrap', 'nowrap', 'clip']),
onChange: PropTypes.func,
onCellsChanged: PropTypes.func,
onContextMenu: PropTypes.func,
onSelect: PropTypes.func,
isCellNavigable: PropTypes.func,
selected: PropTypes.shape({
start: PropTypes.shape({
i: PropTypes.number,
j: PropTypes.number
}),
end: PropTypes.shape({
i: PropTypes.number,
j: PropTypes.number
})
}),
valueRenderer: PropTypes.func.isRequired,
dataRenderer: PropTypes.func,
sheetRenderer: PropTypes.func.isRequired,
rowRenderer: PropTypes.func.isRequired,
cellRenderer: PropTypes.func.isRequired,
valueViewer: PropTypes.func,
dataEditor: PropTypes.func,
parsePaste: PropTypes.func,
attributesRenderer: PropTypes.func,
keyFn: PropTypes.func
}
Happy to create a pull request
This also causes warnings for functional components wrapped in React.memo.