flexbox-react icon indicating copy to clipboard operation
flexbox-react copied to clipboard

Bump to react 16.

Open ayc92 opened this issue 8 years ago • 8 comments

I was able to successfully install and use it in my own respository by manually pushing the dist directory (since I was installing this package from my fork's git URL, the prepublish script doesn't ever get run). I've removed the dist folder in the final diff though :)

  • Bump to react@16 and react-dom@16
  • Bump react/react-dom TS types to ^16
  • Fix snapshots to reflect react 16

ayc92 avatar Jan 15 '18 08:01 ayc92

Looking good @ayc92 but tests not passing. Mind to check it out? I'll gladly merge after that.

nachoaIvarez avatar Jan 22 '18 19:01 nachoaIvarez

@nachoaIvarez I fixed the snapshot tests to reflect the stylis version upgrade. It patches some of the flexbox prefixing to support IE10.

ayc92 avatar Jan 23 '18 18:01 ayc92

I have some issues with TS definitions when trying to use the library with React 16. I think they could be solved by this PR.

ssvendsen avatar Mar 07 '18 11:03 ssvendsen

@nachoaIvarez Is there an ETA for merging this? I just updated to React 16 and this is now happening which I think is solved by this PR.

(3636,13): error TS2403: Subsequent variable declarations must have the same type.  Variable 'a' must be of type 'DetailedHTMLProps<AnchorHTMLAttributes<HTMLAnchorElement>, HTMLAnchorElement>', but here has type 'DetailedHTMLProps<AnchorHTMLAttributes<HTMLAnchorElement>, HTMLAnchorElement>'.```

awjreynolds avatar Mar 28 '18 16:03 awjreynolds

Forked, merged and published as @g07cha/flexbox-react if anyone needs it.

G07cha avatar Aug 13 '19 18:08 G07cha

@G07cha thanks, hope this PR will get merged soon. Till then i will use your version. :)

michaelzoidl avatar Oct 02 '19 16:10 michaelzoidl

I could really use this update

holt-mansfield-finaeo avatar Mar 11 '20 19:03 holt-mansfield-finaeo

@nachoaIvarez are you ok to merge this?

holt-mansfield-finaeo avatar Mar 11 '20 19:03 holt-mansfield-finaeo