react-native-indicators icon indicating copy to clipboard operation
react-native-indicators copied to clipboard

Get rid of spread operator for prop key

Open JimTeva opened this issue 1 year ago • 5 comments

key is a special prop in React that's used for reconciliation. React recommends handling it separately from other props. Generates errors in react-native v75.3 if not handled properly.

JimTeva avatar Sep 28 '24 02:09 JimTeva

+1

charlestbell avatar Nov 18 '24 13:11 charlestbell

+1

OmarSaidIbrahim avatar Nov 21 '24 16:11 OmarSaidIbrahim

I've forked and published the fix here: https://www.npmjs.com/package/@deelo55/react-native-indicators

deelo55 avatar Nov 22 '24 00:11 deelo55

@JimTeva your MR fixes the issue only for BallIndicator component, here is my patch for every indicator type: https://github.com/n4kz/react-native-indicators/issues/43#issuecomment-2514341485

Akatroj avatar Dec 03 '24 11:12 Akatroj

This seems like an abandoned project, last release was 5 years ago. Anyone planning on creating a new fork that will keep up with RN/react?

celleb avatar Jan 06 '25 23:01 celleb