iroh icon indicating copy to clipboard operation
iroh copied to clipboard

tests: add tests for DNS-over-HTTPS to iroh-dns-server

Open Frando opened this issue 4 months ago • 3 comments

Description

Our DoH support in iroh-dns-server is broken: #3737

We didn't have any tests for DoH before.

This adds end-to-end tests that test resolving DoH records via HTTP and HTTPS via reqwest, and via hickory-resolver.

While working on this, I realized that we currently do not change the storage path in tests, which is bad can can lead to very unexpected behavior when running tests concurrently. This also fixes that by allowing to pass in the storage path.

Breaking Changes

Notes & open questions

Change checklist

  • [ ] Self-review.
  • [ ] Documentation updates following the style guide, if relevant.
  • [ ] Tests if relevant.
  • [ ] All breaking changes documented.
    • [ ] List all breaking changes in the above "Breaking Changes" section.
    • [ ] Open an issue or PR on any number0 repos that are affected by this breaking change. Give guidance on how the updates should be handled or do the actual updates themselves. The major ones are:

Frando avatar Dec 08 '25 10:12 Frando

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3745/docs/iroh/

Last updated: 2025-12-23T12:47:31Z

github-actions[bot] avatar Dec 08 '25 10:12 github-actions[bot]

Netsim report & logs for this PR have been generated and is available at: LOGS This report will remain available for 3 days.

Last updated for commit: 87fc4fa

github-actions[bot] avatar Dec 08 '25 10:12 github-actions[bot]

---- http::tests::test_doh stdout ----

thread 'http::tests::test_doh' (6480) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tracing-subscriber-0.3.22/src/fmt/mod.rs:1247:16:
Unable to install global subscriber: SetGlobalDefaultError("a global default trace dispatcher has already been set")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

the cross failure seems real

dignifiedquire avatar Dec 09 '25 13:12 dignifiedquire

@Frando please update and merge

flub avatar Dec 22 '25 16:12 flub

Rebased and addressed review, will merge if green.

Frando avatar Dec 23 '25 12:12 Frando