node icon indicating copy to clipboard operation
node copied to clipboard

[WIP] [Guidance Wanted] Fix arm binaries compilation

Open jgabriel98 opened this issue 2 years ago • 4 comments

Bug description

The build toolchain and ppa packages tells it supports armhf which on debian seems to be arm6 and arm7 (...don't ask me why). But when building for armhf (32bit arm), it was compiling armv7l binaries for armv6l, causing myst executable to crash with "fatal error illegal instruction".

This same problem/bug happened on this other project: https://github.com/goreleaser/goreleaser/issues/2721 So my solution was lightly inspired on it.

Results

Got it working on my raspbery pizero W, with both

  • directly running ./myst binaries (dynamic and static compilation)
  • generating .deb package and installing it

It was crosscompiled from a linux x86_64 machine.


Note

Currently this PR is incomplete and can only generate the

  • armv6 binaries (see buildBinaryFor() and packageStandalone() changes)
  • .deb package (see PackageLinuxDebianArmv6l() changes)
  • static build binaries (see PackageLinuxArmv6l() changes)

It didn't know what more needed to be refactored, since i don´t know how what happens after artifacts gets uploaded to S3 bucket.

So any assistance is welcome. Also feel free to reach on discord, i'm on the mysterium-network channel! (user: #gaba3535)

jgabriel98 avatar Jan 08 '24 03:01 jgabriel98

@jgabriel98 hey, thanks you for contribution, we will be on this ASAP 🎉

mdomasevicius avatar Jan 09 '24 09:01 mdomasevicius

@jgabriel98 hey, thanks you for contribution, we will be on this ASAP 🎉

@mdomasevicius You're welcome! no problems. Let me know of any updates on this, if possible.

jgabriel98 avatar Jan 09 '24 14:01 jgabriel98

Hey there, sorry for taking that long. I have a full time job as a developer, so i didn't got much free time to take a look into this.

I'll try to implement whats left on this week.

jgabriel98 avatar Jan 23 '24 05:01 jgabriel98

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 06 '24 06:02 stale[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 24 '24 16:02 stale[bot]

This pull request has been automatically closed because it has not had activity for a long time. If this pull request is still valid, please ping a maintainer and ask them to label it as "pinned". Thank you for your contributions.

stale[bot] avatar Mar 10 '24 17:03 stale[bot]