mouselock icon indicating copy to clipboard operation
mouselock copied to clipboard

Initial menubar feature, changed content view to settings pane

Open relalis opened this issue 2 years ago • 8 comments

Initial implementation of feature requested by #9, could use some cleaning up

relalis avatar Mar 31 '23 06:03 relalis

If you activate mouselock always, you can't reach the menubar and disable it, which locks your mouse permanently. When it's running as a window app you can always cmd+tab and cmd+q to stop it.

I'm not really sure that I like it as a menubar app. I don't know if that issue can be solved in a proper way.

mxrlkn avatar Mar 31 '23 20:03 mxrlkn

you suggested in the issue to disable the "Always" lock when it's in menubar mode; I think that would be a clean workaround for now. A global hotkey combo to completely disable mouselock is also an idea, I'll put it on the backlog and test it out when I have some free time

relalis avatar Mar 31 '23 21:03 relalis

@relalis can you fork this and implement your PR and release it?

i only use this for LoL so the whole locking issue doesn't apply to me

ghost avatar Mar 24 '24 17:03 ghost

@relalis can you fork this and implement your PR and release it?

i only use this for LoL so the whole locking issue doesn't apply to me

I already have a fork that this PR is based on, you're welcome to build and run it. A release is available here.

Apple decided to deprecate Settings in favor of SettingsLink, which breaks this PR on macOS 14 and above and could require a full rewrite to avoid more overhead/bugs; in all cases, this whole project is a demonstrable failure on Riot's end to implement a simple NSTrackingArea in their main window with a mouseExited() callback. League players shouldn't have to use a hacky workaround that adds unnecessary overhead, but here we are.

relalis avatar Mar 24 '24 21:03 relalis

@relalis thank you for the release!

I've been looking into mouselock trying to understand what causes the polling rate issue. Apparently if you use a mouse with a polling rate > 250hz the cursor goes crazy in game.

Do you know what could be the cause?

pldumn avatar Mar 27 '24 04:03 pldumn

@relalis thank you for the release!

I've been looking into mouselock trying to understand what causes the polling rate issue. Apparently if you use a mouse with a polling rate > 250hz the cursor goes crazy in game.

Do you know what could be the cause?

I honestly couldn't say; I don't really know much Swift, I just really liked the project and thought I'd add a little to it. I'll try to replicate sometime and see if I can debug, but no promises.

relalis avatar Mar 27 '24 04:03 relalis

@relalis thank you for the release!

I've been looking into mouselock trying to understand what causes the polling rate issue. Apparently if you use a mouse with a polling rate > 250hz the cursor goes crazy in game.

Do you know what could be the cause?

Turn off software mouse in game settings.

ghost avatar Mar 27 '24 11:03 ghost

@relalis thank you!

@kejedi tried it but didn't work unfortunately. If mouselock is not running the mouse works normally, it only does that when it is running.

pldumn avatar Mar 31 '24 22:03 pldumn

as explained here https://github.com/mxrlkn/mouselock/issues/9#issuecomment-2276791019 I've decided that it's better that it'll not be a menubar app after all. I just think it's simpler without. And also this problem should not still be a thing.

Surely Riot will fix this soon (aware)

mxrlkn avatar Aug 08 '24 22:08 mxrlkn