Max Howell
Max Howell
Last time I was in here `/repos/:user/:repo/git/refs/tags` was paginated returning at most 100 tags. Maybe I'm wrong though. Certainly if we *can* do it without auth I'm all for it....
oh interesting, nice find! So I’m cool with `getVersions` using `/repos/:user/:repo/git/refs/tags` if no `GITHUB_TOKEN` is provided. Rationale: we only use this for builds currently, and making this change additive is...
In fact we now iterate *all tags* since we can't guarantee anything about date order and semver order.
Yeah this is a bug in our curl handling, reopening.
Yeah actually I cannot figure out why it doesn’t error cleanly. Is is possible the URL you downloaded returns a HTTP 200 even though it didn’t actually provide a tarball?
right, content type is HTML. We could probs figure this out and give a better error. Will leave open until we do that.
Sorry I was busy for months and couldn't get to all the OSS requests. This looks good. I'll see why the checks didn't run
v7 was maybe good, but ultimately I lacked the enthusiasm to release something with such breaking changes for a project I no longer actively use.
added you to owners Roman.
You already were added @RomanPodymov but I upgraded you to “owner” in case that helps.