Workbench icon indicating copy to clipboard operation
Workbench copied to clipboard

Support Larger Files with Asset Data Type

Open ezfe opened this issue 7 years ago • 2 comments

I put this PR together to show how this would work, and did a quick test to make sure it worked. This pull request changes the data type from Bytes to Asset, and creates a new CKAsset when uploading.

Note: This does not convert existing records, so I changed the field name from data to asset to keep compatibility.

screen shot 2019-02-20 at 12 23 23 am

ezfe avatar Feb 20 '19 05:02 ezfe

I am actually reluctant to change this before someone presents rationale for it.

The tool is not designed for large files, we don’t diff for example, so everything is uploaded/downloaded every time a change happens.

mxcl avatar Feb 20 '19 15:02 mxcl

Of course, that makes sense, I didn't put much work into this and I just wanted to see your thoughts. Feel free to close this PR at your own discretion.

ezfe avatar Feb 20 '19 16:02 ezfe