PromiseKit icon indicating copy to clipboard operation
PromiseKit copied to clipboard

Remove wrappers in v7

Open GarthSnyder opened this issue 4 years ago • 4 comments

The current v7 implementation of the Dispatcher protocol requires function wrappers, which create significant noise and maintenance burden.

SE-0299, which provides a way for protocol types to simulate the presence of static members, is likely to make the wrappers unnecessary.

The implementation of SE-0299 is complete and due to be released in Swift 5.5. Use of this feature would make Swift 5.5 a prerequisite for v7.

GarthSnyder avatar Jun 01 '21 22:06 GarthSnyder

Probs doesn’t need to hold up v7 though, or you think otherwise?

mxcl avatar Jun 01 '21 23:06 mxcl

Like, I believe I can tag 7.0.0 as it stands.

mxcl avatar Jun 02 '21 00:06 mxcl

As far as I know, the current code base should work as-is. If you're hoping to get v7 out before WWDC, this particular update can wait. It won't change the API, though it might change Xcode's code completion or visual display.

I would imagine that an Xcode beta that includes Swift 5.5 will be released for WWDC on June 7. It should be pretty easy to assess at that point whether SE-0299 is going to be of help for v7. If so, I don't think the implementation will take that long.

Just as a general question, are you willing to require a beta version of Xcode in order to support v7?

GarthSnyder avatar Jun 02 '21 00:06 GarthSnyder

If you're hoping to get v7 out before WWDC

This final push is more I have time, WWDC is a coincidence.

Just as a general question, are you willing to require a beta version of Xcode in order to support v7?

Only for betas, I believe is the correct choice there.

mxcl avatar Jun 02 '21 00:06 mxcl