spec icon indicating copy to clipboard operation
spec copied to clipboard

To be discussed: Do we need pretty name for feature group?

Open danielmuellerma opened this issue 6 years ago • 9 comments

Feature Group has xml attribute "Pretty" - but pretty for feature groups is not defined in Appendix B. We should either define pretty names for feature groups in Appendix B or remove xml attribute "Pretty". Feature does not have xml attribute "Pretty".

danielmuellerma avatar Jun 14 '19 14:06 danielmuellerma

The whole "pretty" concept is not explained anywhere.

petrvanekrobe avatar Jun 14 '19 14:06 petrvanekrobe

@petrvanekrobe the meaning is the same as Short name in Fixture Type. But you are right, we should change description of pretty name xml attribute, "The pretty name of the attribute ." - explains nothing.

AndriiVoitenko avatar Jun 15 '19 19:06 AndriiVoitenko

As discussed before the winter break, i added human aimed label to each attribute, it is in the Attributes with extended description branch, original PR: https://github.com/mvrdevelopment/spec/pull/122

This commit: https://github.com/mvrdevelopment/spec/pull/122/commits/0d2423f1cd1206ec1e1b1a88b5b4ee710190ce3b

I did as little editorializing as possible. @moritzstaffel i think this is ready to be used in the Builder to provide a bit better label for the user.

petrvanekrobe avatar Jan 05 '24 15:01 petrvanekrobe

@petrvanekrobe I will have a look. Should I take care about getting this branch https://github.com/mvrdevelopment/spec/pull/122 into the main

moritzstaffel avatar Jan 05 '24 15:01 moritzstaffel

I can get that in. We could also merge in the Wireshark dissector and the MVR schema, what do you think?

petrvanekrobe avatar Jan 05 '24 15:01 petrvanekrobe

I think this is a good thing!

moritzstaffel avatar Jan 05 '24 15:01 moritzstaffel