Updated gdtf xsd to gdtf 1.2

[Verschwiegener]

#194

[petrvanekrobe]

Thank you @Verschwiegener for the update, this is great. I tested it and it needs some small changes, but it improves the XSD nicely.

[Verschwiegener]

Thanks! I have already done some changes but haven't pushed them yet. What else needs changing so I could implement it?

[petrvanekrobe]

Thank you! I have tested it an it seems that all issues it has found were valid, so i don't think i have anything to add here... :)

[petrvanekrobe]

@Verschwiegener besides the small proposed changes, are you planning to push in more stuff or can we merge this in as is?

[Verschwiegener]

Sorry I couldn't push the changes yet, I was bussy the last few weeks. I should be able to push them in the coming week

[Verschwiegener]

Another error of the xsd that i found by testing it against gdtf files is that the Wheel Slat name should not be unique (https://github.com/mvrdevelopment/spec/blob/main/gdtf-spec.md#table-12-wheel-slot-attributes) is this desired behavior or should the name be unique?

[petrvanekrobe]

Another error of the xsd that i found by testing it against gdtf files is that the Wheel Slat name should not be unique (https://github.com/mvrdevelopment/spec/blob/main/gdtf-spec.md#table-12-wheel-slot-attributes) is this desired behavior or should the name be unique?

Thank you for asking. The slot name should not be unique anymore, we changed it from Name to String and also updated the description. The Next branch is tracking the confirmed updates to the Spec for next release.

[petrvanekrobe]

Thank you for all the work. I will merge this in early December, future improvements can be done in follow up PRs. Please rebase. Also please ideally machine format. Same for the MVR one.

[Verschwiegener]

To which branch should I rebase the pull request?

[petrvanekrobe]

I would choose main. I am sorry if previously for the MVR XSD i might have mentioned the next branch, but i think it is better to keep Next only for changes related to the Spec, so it is later easy to see changelog there.

[Verschwiegener]

I hope i used the right format settings but it should be all good now

[petrvanekrobe]

@Verschwiegener thank you, this looks good, i tested on several files. My formatting tool gives different result, but this is absolutely fine.

In order for it to compile under xmllint, these small changes need to be done (notice the space preceding the quotation marks):

diff gdtf.xsd gdtf_mine.xsd 
588c588
<                     <xs:attribute name="ConnectorType " type="xs:string"/>
---
>                     <xs:attribute name="ConnectorType" type="xs:string"/>
627c627
<                   <xs:attribute name="CrossSectionType " type="CrossSectionType"/>
---
>                   <xs:attribute name="CrossSectionType" type="CrossSectionType"/>
638c638
<                   <xs:attribute name="SupportType " type="SupportType"/>
---
>                   <xs:attribute name="SupportType" type="SupportType"/>
1226c1226
< <xs:simpleType name="CrossSectionType ">
---
> <xs:simpleType name="CrossSectionType">
1238c1238

[petrvanekrobe]

Thank you, seems good now :+1: