Fixes #953 - AttributeError: 'list' object has no attribute 'verify' when you pass in list wsse
A simple bugfix for #953 'AttributeError: 'list' object has no attribute 'verify'' that occurs when the user passes in a list with UsernameToken() and Signature() to the wsse argument in the Client class.
Codecov Report
Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
Project coverage is 89.37%. Comparing base (
aae3def) to head (085c33a). Report is 167 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/zeep/wsdl/bindings/soap.py | 25.00% | 2 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #1077 +/- ##
==========================================
+ Coverage 89.34% 89.37% +0.02%
==========================================
Files 65 65
Lines 4845 4848 +3
Branches 850 852 +2
==========================================
+ Hits 4329 4333 +4
Misses 333 333
+ Partials 183 182 -1
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/zeep/wsdl/bindings/soap.py | 82.90% <25.00%> (-1.31%) |
:arrow_down: |
Would passing usernametoken as it is , not a list work post this is merged ?
Would passing usernametoken as it is , not a list work post this is merged ?
Yes, behaviour only changes if isinstance(client.wsse, list) returns True