MuseScore icon indicating copy to clipboard operation
MuseScore copied to clipboard

Moving pianoroll changes into new PR.

Open blackears opened this issue 4 years ago • 4 comments

Resolves: (direct link to the issue)

(short description of the changes and the motivation to make the changes)

  • [ ] I signed CLA
  • [ ] I made sure the code in the PR follows the coding rules
  • [ ] I made sure the code compiles on my machine
  • [ ] I made sure there are no unnecessary changes in the code
  • [ ] I made sure the title of the PR reflects the core meaning of the issue you are solving
  • [ ] I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • [ ] I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [ ] I created the test (mtest, vtest, script test) to verify the changes I made

blackears avatar Sep 13 '21 10:09 blackears

This replaces https://github.com/musescore/MuseScore/pull/9033 which has gotten unmanageable.

blackears avatar Sep 13 '21 10:09 blackears

A rebase is needed.

RobFog avatar Mar 17 '22 00:03 RobFog

Looks like Github just upgraded its security. I need to change all my keys first.

blackears avatar Mar 17 '22 00:03 blackears

One unit test failed, see https://github.com/musescore/MuseScore/runs/5579586289?check_suite_focus=true#step:8:1231

I believe the reason is https://github.com/musescore/MuseScore/pull/9109#discussion_r828859482

Jojo-Schmitz avatar Mar 17 '22 08:03 Jojo-Schmitz

Just adding a link to Piano Roll Editor bug reports and requests located in the MuseScore discussion area.

https://github.com/orgs/musescore/discussions/16925

scorster avatar Nov 29 '23 22:11 scorster