MuseScore icon indicating copy to clipboard operation
MuseScore copied to clipboard

Change Hide/delete to Hide/Delete.

Open Rishav1707 opened this issue 3 years ago • 7 comments

Resolves: #15672

  • [x] I signed the CLA
  • [x] The title of the PR describes the problem it addresses
  • [x] Each commit's message describes its purpose and effects, and references the issue it resolves
  • [x] If changes are extensive, there is a sequence of easily reviewable commits
  • [x] The code in the PR follows the coding rules
  • [x] There are no unnecessary changes
  • [x] The code compiles and runs on my machine, preferably after each commit individually

Rishav1707 avatar Jan 02 '23 13:01 Rishav1707

Capture+_2023-01-02-16-47-59(1)

Seems that you mistakingly changed other "deletes" to start with a capital letter (as shown above). Only "Hide/delete" should be changed to "Hide/Delete"

PetJer avatar Jan 02 '23 17:01 PetJer

Also must all the instances in the .ts files be updated? I thought they were something that were generated automatically

HowardC2019 avatar Jan 03 '23 04:01 HowardC2019

Capture+_2023-01-02-16-47-59(1)

Seems that you mistakingly changed other "deletes" to start with a capital letter (as shown above). Only "Hide/delete" should be changed to "Hide/Delete"

Done @PetJer

Rishav1707 avatar Jan 03 '23 08:01 Rishav1707

The .ts files should also stay unchanged indeed; those are re-generated automatically at the moments that we need them.

cbjeukendrup avatar Jan 03 '23 13:01 cbjeukendrup

The .ts files should also stay unchanged indeed; those are re-generated automatically at the moments that we need them.

What does it mean? I am not able to understand and what I have to do now?

Rishav1707 avatar Jan 03 '23 14:01 Rishav1707

You should undo the changes to the files with the .ts extension. There should be only one change, namely the one in src/palette/qml/MuseScore/Palette/internal/TreePaletteHeader.qml. The other changes should be removed from this PR.

cbjeukendrup avatar Jan 03 '23 14:01 cbjeukendrup

You should undo the changes to the files with the .ts extension. There should be only one change, namely the one in src/palette/qml/MuseScore/Palette/internal/TreePaletteHeader.qml. The other changes should be removed from this PR.

Ok I'll undo these changes

Rishav1707 avatar Jan 03 '23 14:01 Rishav1707

Almost there! The changes in share/locale/musescore_af.ts need to be undone too...

Once that is done, it would be great if you could squash the commits, so that you have 1 commit containing 1 changed file. The easiest way is using GitHub Desktop, which I do recommend.

cbjeukendrup avatar Jan 04 '23 12:01 cbjeukendrup

Almost there! The changes in share/locale/musescore_af.ts need to be undone too...

Once that is done, it would be great if you could squash the commits, so that you have 1 commit containing 1 changed file. The easiest way is using GitHub Desktop, which I do recommend.

Done @cbjeukendrup

Rishav1707 avatar Jan 04 '23 12:01 Rishav1707