MuseScore icon indicating copy to clipboard operation
MuseScore copied to clipboard

minor tweak in key sig editor - first added accidental aligned to "zero" position

Open sammik opened this issue 3 years ago • 1 comments

In Custom Key Signatures Editor - now, also firstly added accidental is alligned to its default "zero" position, unless Ctrl is pressed.

(Before, "zero position" was calculated from most left accidental.)

  • [x] I signed CLA
  • [x] I made sure the code in the PR follows the coding rules
  • [x] I made sure the code compiles on my machine
  • [x] I made sure there are no unnecessary changes in the code
  • [x] I made sure the title of the PR reflects the core meaning of the issue you are solving
  • [x] I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • [x] I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [ ] I created the test (mtest, vtest, script test) to verify the changes I made

sammik avatar Nov 04 '22 13:11 sammik

Before, not possible to set offset of first accidental:

https://user-images.githubusercontent.com/1646034/208679433-a3d58a7b-7bfd-4190-aca0-3e02d30a6252.mp4

After, zero taken by default (but also possible to set offset of first accidental):

https://user-images.githubusercontent.com/1646034/208679566-900ba5ae-eacf-4911-af4e-bfde8dd84bcf.mp4

@oktophonie

sammik avatar Dec 20 '22 13:12 sammik

@sammik please rebase

RomanPudashkin avatar Apr 18 '24 08:04 RomanPudashkin

@RomanPudashkin done

sammik avatar Apr 18 '24 19:04 sammik

Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved

zacjansheski avatar Apr 19 '24 16:04 zacjansheski