musescore
Fix #10601: Added Edit and Reset workspace button
Resolves: #10601
- [x] I signed CLA
- [x] I made sure the code in the PR follows the coding rules
- [x] I made sure the code compiles on my machine
- [x] I made sure there are no unnecessary changes in the code
- [x] I made sure the title of the PR reflects the core meaning of the issue you are solving
- [x] I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
- [x] I made sure the commit message title starts with "fix #424242:" if there is a related issue
- [ ] I created the test (mtest, vtest, script test) to verify the changes I made
I'm unable to test this because the builds have expired. @HemantAntony - can you fix this up and I'll take a look? Thanks!
@Eism - I do worry (from what you are saying) that there might be some redundancy here. Need to test it to be sure.
@Eism
What do you think about adding these two operations to the Workspaces dialog for each workspace? Like in Parts dialog
I agree. @HemantAntony - I don't think this is the right place to put those options because they are hard to find and are much less clear than they would be if they were located in the 'Configure Workspaces' popup. I'd suggest leaving the options in the top menu but also creating some UI options in the Workspace popup itself.
Perhaps @bkunda can help with this?
Actually, I'm confused about what 'Reset Workspace' is supposed to do. In this build, it seems to simply choose the default workspace and that's it. Even if I change the default workspace, pressing 'Reset' doesn't do anything.
If this is all it does, then I don't think we should have this option at all. Anyone have any ideas?
I can tell you what I would want it to, which is not what it has done in the past: I'd want it to reset any customizations I had made during that particular editing session. So if I had a nice carefully customized workspace I had been using for weeks, then one day I accidentally messed it up, I could easily go back to the way it was when I started that session. This would be easy to implement I think since as far as I know we don't actually write the customizations out until your either close the window or change workspaces. So basically it would just amount to reloading the current workspace.
What it actually did in MU3 was something rather different, and sort of useful but not really. When you create a workspace, it's cloned from whatever workspace you are in. So you can start form either Basic and add to it, or from Advanced and subtracted from it. Reset takes you back to either Basic or Advanced - whichever your workspace was based on. You can also base one custom workspace off of another, which is nice, but reset still takes you all the way back to Basic or Advanced rather than back to the workspace you actually based yours on. Seems like there was some technical reason for that but I don't remember.
So, I guess you'd need two options then:
Reset workspace: does what it says - resets the selected workspace back to the initial default the app is loaded with. Anything else is just confusing.
Undo changes to workspace in this session: again, does what it says, although I'd like to think of a snappier name. Perhaps Undo recent changes?
And these options should be clearly applicable to individual workspaces, possibly using a '...' button on each.
@HemantAntony - if you think you'd be comfortable implementing a design like we've just discussed, I can put it together for you?
Apologies for the changes. The MS3 system just feels dislocated and hard to understand. I still don't actually know what it exactly does!
Hey @HemantAntony, I wasn't aware I needed to do anything. 😆 I did just try to grab a build but it has expired.
Have you implemented changes and want them tested?
Ah no 😁. You had said that you would implement a design for 'Edit workspace' and 'Undo recent changes' in the above comments
Sure. I think you're right that it needs a visualisation (and possibly a little double-checking on the UX). I'll bump this over to @bkunda and @jessjwilliamson. They'll likely be able to bang it out quite quickly and give it to you.
Right now, I'm a bit too consumed with other things to do the design myself. Apologies!