MuseScore icon indicating copy to clipboard operation
MuseScore copied to clipboard

[MU4 Issue] Typing values into style fields triggers updates on each keystroke

Open its-not-nice opened this issue 3 years ago • 3 comments

Describe the bug Perhaps more of a request or suggestion than a 'bug', but I'll explain why it is a problem.

For example: let's say I want to change my page width to 184mm. I open format > Page settings and select the value currently in the page width field (210mm) for me.

I can get the width I want by typing "184". But the score updates on every keystroke, and other settings can be affected too. In this case, as soon as I type "1", the score becomes 1mm wide, and also the margins become 1mm (constrained as such by the width):

image

and when I type the "8" and "4" the margins obviously do not increase again, so while I have successfully set my desired page width, my margins are now messed up.

This applies to all fields in the Page settings dialog and also the main Style dialog.

As well as being annoying, a full recomputation of the score layout happens with each keystroke too. In the case of a large, complex score this can be very slow, and if you are typing multiple digits into a style field, you are likely to see nonsense until they are all typed (plus it runs the risk of messing the layout up in unpredictable ways).

Would it be possible for the 'value updated' message to be sent not on every keystroke, but only by some appropriate trigger, for instance tabbing or clicking away from the field?

its-not-nice avatar Sep 10 '22 09:09 its-not-nice

Here comes another idea (not related to the issue):

image

If the unit would be excluded from the field, typing in values would be easier.

(Strictly speaking the unit wouldn't need to be shown at all, as it is selected globally in the same window.)

oMrSmith avatar Sep 10 '22 10:09 oMrSmith

I'd certainly call it bug if you can't type in a new page width without having your margins changed to something impractical in the process. The question is what the desired behaviour is - either use debounce (wait a small period before updating) or require a focus change.

wizofaus avatar Sep 11 '22 03:09 wizofaus

Yes. This is extremely annoying. The update should occur after the user clicks on another field or presses 'OK', etc. It should not update with every digit added.

Tantacrul avatar Sep 15 '22 21:09 Tantacrul

@oktophonie Check #15107

I have removed all updating for both Page Settings and Style Dialogs. I didn't test all of it. But I'm confident :)

HemantAntony avatar Dec 11 '22 10:12 HemantAntony

How about instrument names? That's where I experience this most, trying to rename an instrument and having to wait after each letter.

MarcSabatella avatar Dec 11 '22 14:12 MarcSabatella

@MarcSabatella @oktophonie Here? image

HemantAntony avatar Dec 12 '22 13:12 HemantAntony

Yes

MarcSabatella avatar Dec 12 '22 13:12 MarcSabatella

@MarcSabatella @oktophonie I have updated my PR. It should include that now :)

HemantAntony avatar Dec 14 '22 15:12 HemantAntony