MuseScore icon indicating copy to clipboard operation
MuseScore copied to clipboard

[MU4 Issue] Playing with Midi Keyboard

Open RafaelLiebermann opened this issue 3 years ago • 4 comments

Assigning play button in MIDI mappings causes broken 'Play' functionality.

Steps to reproduce the behaviour: See @jessjwilliamson's video in the comments down below. This demonstrates the problem perfectly.

Windows 11 Pro 22h2 Dev build 22593

RafaelLiebermann avatar Apr 30 '22 18:04 RafaelLiebermann

Similar to #11234?

rgreen5 avatar May 01 '22 13:05 rgreen5

@RafaelLiebermann Is this what you're experiencing? Sound on! :)

https://user-images.githubusercontent.com/71656189/167850330-a0e6514d-4ab4-4cbc-badd-fddb08601e4f.mp4

jessjwilliamson avatar May 11 '22 12:05 jessjwilliamson

Yes it is


From: jessjwilliamson @.> Sent: Wednesday, May 11, 2022 1:31:42 PM To: musescore/MuseScore @.> Cc: Rafael Liebermann @.>; Mention @.> Subject: Re: [musescore/MuseScore] [MU4 Issue] Playing with Midi Keyboard (Issue #11480)

@RafaelLiebermannhttps://github.com/RafaelLiebermann Is this what you're experiencing? Sound on! :)

https://user-images.githubusercontent.com/71656189/167850330-a0e6514d-4ab4-4cbc-badd-fddb08601e4f.mp4

— Reply to this email directly, view it on GitHubhttps://github.com/musescore/MuseScore/issues/11480#issuecomment-1123697831, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASJNK3DCO7G25F6XUC3QUMTVJOSC5ANCNFSM5UYWW3DQ. You are receiving this because you were mentioned.Message ID: @.***>

RafaelLiebermann avatar May 11 '22 12:05 RafaelLiebermann

@jessjwilliamson - fantastic. Thanks for that!

I've added a priority and I'm now reassigning to the development team. I've also updated the issue description and cleared out all the comments (mainly me) to make the issue easier to understand. Thanks again!

Tantacrul avatar May 11 '22 14:05 Tantacrul

🟢 FIXED in https://github.com/musescore/MuseScore/pull/12735 Tested on macOS 12, Win 11, Ubuntu 20

abariska avatar Aug 25 '22 14:08 abariska

Hey guys I'm afraid it's still not working. Hard to explain by text so I'm showing it here on video. Sound on!

https://user-images.githubusercontent.com/71656189/187680587-3f93b496-506f-4208-bbe9-8290e513563b.mp4

jessjwilliamson avatar Aug 31 '22 12:08 jessjwilliamson

@jessjwilliamson could you do the same flow with another midi device?

JFYI Actually, this area need more attention and effort. When I closed this issue I've created three more complicated issues https://github.com/musescore/MuseScore/issues/13028 https://github.com/musescore/MuseScore/issues/13030 https://github.com/musescore/MuseScore/issues/13031

abariska avatar Aug 31 '22 12:08 abariska

I would log the 'Active' / 'Inactive' visual UI issue as a separate bug and mark it with P3 and Community tags.

I'd say some local hero may jump in to fix it separately.

Tantacrul avatar Aug 31 '22 12:08 Tantacrul

I would log the 'Active' / 'Inactive' visual UI issue as a separate bug and mark it with P3 and Community tags.

I'd say some local hero may jump in to fix it separately.

Beat you to it :) https://github.com/musescore/MuseScore/issues/13098 with a question for you inside

jessjwilliamson avatar Aug 31 '22 13:08 jessjwilliamson

@jessjwilliamson could you do the same flow with another midi device?

JFYI Actually, this are need more attention and effort. When I closed this issue I've created three more complicated issues #13028 #13030 #13031

Damn. Now I'm testing on a different device and it works. Hmm. I wonder if it's got to do with old vs new devices? Initially I was using a Roland RD-170 which is a keyboard made in the mid 00's. Just tested with a modern keyboard AKAI LPK25 and it works just fine. Why is this happening?

jessjwilliamson avatar Sep 01 '22 17:09 jessjwilliamson

@boryskuzmenko / @DmitryArefiev - can you test your devices and say whether this issue is happening for you?

@jessjwilliamson - to confirm: the problem is keyboard specific? So it is still happening with your Roland but not your AKAI?

Tantacrul avatar Sep 01 '22 17:09 Tantacrul

@jessjwilliamson - to confirm: the problem is keyboard specific? So it is still happening with your Roland but not your AKAI?

I tried different types of connections:

  1. Keyboard direct to USB on PC machine
  2. Keyboard to audio interface then PC.

Roland is still having problems. I've done MIDI mapping on Ableton with Roland and it works fine so it's not my keyboard. the only difference is that my Roland has MIDI In and Out ports at the back of the keyboard. My Akai has mini USB. I'm out of ideas what it could be. I looked into MIDI message readers - all looks okay from here.

jessjwilliamson avatar Sep 02 '22 11:09 jessjwilliamson

@Tantacrul @jessjwilliamson My Arturia KeyLab61 Essential (USB) works fine on Windows10

https://user-images.githubusercontent.com/90187801/188153989-5257845b-4146-41fc-ac9c-d8e76ba3d825.mp4

The reason for appearing that strange bug could be #13028 (More than one midi parameter can be mapped to one MU parameter).

As I see from Roland RD-170 description it has "88 Weighted Keys with Touch-Sensitivity hammered action (New)". Maybe that high quality keyboard has more MIDI messages than usual keyboard during one key press.

Interesting to compare MIDI messages during one key press between Roland RD-170 and AKAI LPK25 (using some MIDI monitor app). Or just to fix #13028 and to see how it goes with Roland RD-170

DmitryArefiev avatar Sep 02 '22 13:09 DmitryArefiev

@Tantacrul @jessjwilliamson My Arturia KeyLab61 Essential (USB) works fine on Windows10

bandicam.2022-09-02.16-14-03-487.mp4 The reason for appearing that strange bug could be #13028 (More than one midi parameter can be mapped to one MU parameter).

As I see from Roland RD-170 description it has "88 Weighted Keys with Touch-Sensitivity hammered action (New)". Maybe that high quality keyboard has more MIDI messages than usual keyboard during one key press.

Interesting to compare MIDI messages during one key press between Roland RD-170 and AKAI LPK25 (using some MIDI monitor app). Or just to fix #13028 and to see how it goes with Roland RD-170

Ohh.. I have another hammer-weighted keys keyboard I can test with. Will try test that

jessjwilliamson avatar Sep 02 '22 13:09 jessjwilliamson

I'd fix this two issue first https://github.com/musescore/MuseScore/issues/13028 https://github.com/musescore/MuseScore/issues/13030 and see. It really can be the same root issue

abariska avatar Sep 02 '22 13:09 abariska

Just tried on another hammer-weighted keyboard - Yamaha CLP-411. Also old-fashioned with MIDI in and Out cables only on the back. Also does the same bug. Could be a non USB wire cable issue or something else. Seems all USB connected only keyboard word, just not the old fashioned MIDI in and out cables.

jessjwilliamson avatar Sep 02 '22 14:09 jessjwilliamson

I'd fix this two issue first #13028 #13030 and see. It really can be the same root issue

13028 attached video doesn't work can you try re-uploading again please :)

jessjwilliamson avatar Sep 02 '22 14:09 jessjwilliamson

🟢 FIXED Tested on macOS 12, Win 11, Ubuntu 20

abariska avatar Sep 27 '22 09:09 abariska

Hi, I have the exact same issue using a Novation Launchkey Mini MK3, with OS: Windows 10 Version 2009, Arch.: x86_64, MuseScore version (64-bit): 4.0.0-223472200, revision: github-musescore-musescore-5485621. Are there any incompatibilities with some keyboards ?

Julien441Lab avatar Jan 02 '23 13:01 Julien441Lab