Matteo Muraca

Results 19 comments of Matteo Muraca

I really really like this approach. I feel that things are simpler and more intuitive.

We currently have a simple wallet integration test in CI, to ensure that the wallet connects to the local node: https://github.com/Off-Narrative-Labs/Tuxedo/blob/36d7baca4ae159d77ea545d7cb999bd1e715557d/wallet/test.sh#L1-L6 The CI job fails if the wallet can't connect...

Am I missing something, or can we just ditch the `Sr25519SignatureCheck` struct and provide a `type Sr25519SignatureCheck = SignatureCheck< sr25519::Pair>;` with doc comments?

In the past PRs I have done I have marked all the storage items as pub, however take my words with a grain of salt as I'm just a mere...

Hi folks! I have two questions: 1. What should the deprecation message look like? At the moment, I put "#[pallet::getter] is deprecated and will be unavailable in future versions.". 2....

@KiChjang for that you can manually implement a getter function.

I might still be onboard to do this, if it is actually confirmed and non-controversial, and if we have a well defined way on how to proceed. I suggest to...

I just opened a new issue to track the work in all the various pallets. According to the [deprecation checklist](https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/DEPRECATION_CHECKLIST.md) I should add the deprecation message first. Is "`pallet::getter` will...

I'm fine with not following the deprecation checklist, due to the wide impact of this change