mx-chain-go icon indicating copy to clipboard operation
mx-chain-go copied to clipboard

Merge chain go sdk to refactor nov 3

Open raduchis opened this issue 2 years ago • 1 comments

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

raduchis avatar Nov 07 '23 10:11 raduchis

Codecov Report

Attention: 208 lines in your changes are missing coverage. Please review.

Comparison is base (3b96341) 79.04% compared to head (a37c8f2) 79.20%. Report is 1 commits behind head on feat/chain-go-sdk-refactor.

:exclamation: Current head a37c8f2 differs from pull request most recent head 890d968. Consider uploading reports for the commit 890d968 to get more accurate results

Additional details and impacted files
@@                      Coverage Diff                       @@
##           feat/chain-go-sdk-refactor    #5690      +/-   ##
==============================================================
+ Coverage                       79.04%   79.20%   +0.16%     
==============================================================
  Files                             762      800      +38     
  Lines                           96079    97769    +1690     
==============================================================
+ Hits                            75943    77436    +1493     
- Misses                          14721    14811      +90     
- Partials                         5415     5522     +107     
Files Coverage Δ
api/groups/vmValuesGroup.go 100.00% <100.00%> (ø)
common/converters.go 100.00% <100.00%> (ø)
common/enablers/enableEpochsHandler.go 100.00% <100.00%> (ø)
common/ordering/orderedCollection.go 100.00% <100.00%> (ø)
common/statistics/osLevel/memStats.go 97.95% <100.00%> (ø)
...ataRetriever/dataPool/headersCache/headersCache.go 90.29% <100.00%> (+0.14%) :arrow_up:
dataRetriever/dataPool/headersCache/headersPool.go 100.00% <100.00%> (ø)
dataRetriever/factory/dataPoolFactory.go 93.63% <100.00%> (ø)
...ontainer/shardRequestersContainerFactoryCreator.go 100.00% <100.00%> (ø)
...sovereignShardRequestersContainerFactoryCreator.go 100.00% <100.00%> (ø)
... and 53 more

... and 87 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 07 '23 13:11 codecov[bot]