mx-chain-go icon indicating copy to clipboard operation
mx-chain-go copied to clipboard

Feat/consensus model v2

Open SebastianMarian opened this issue 3 years ago • 1 comments

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

SebastianMarian avatar Mar 09 '23 10:03 SebastianMarian

Codecov Report

Patch coverage: 83.35% and project coverage change: +0.15 :tada:

Comparison is base (3f5fffe) 70.80% compared to head (f0d6c33) 70.95%.

:exclamation: Current head f0d6c33 differs from pull request most recent head 51e03da. Consider uploading reports for the commit 51e03da to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5070      +/-   ##
==========================================
+ Coverage   70.80%   70.95%   +0.15%     
==========================================
  Files         649      678      +29     
  Lines       85356    87793    +2437     
==========================================
+ Hits        60435    62297    +1862     
- Misses      20388    20830     +442     
- Partials     4533     4666     +133     
Impacted Files Coverage Δ
...termui/view/termuic/termuiRenders/widgetsRender.go 2.97% <0.00%> (ø)
consensus/spos/bls/constants.go 100.00% <ø> (ø)
...ever/requestHandlers/requesters/headerRequester.go 100.00% <ø> (ø)
...r/requestHandlers/requesters/miniblockRequester.go 100.00% <ø> (ø)
...Handlers/requesters/peerAuthenticationRequester.go 100.00% <ø> (ø)
...requestHandlers/requesters/transactionRequester.go 100.00% <ø> (ø)
...er/requestHandlers/requesters/trieNodeRequester.go 100.00% <ø> (ø)
...questHandlers/requesters/validatorInfoRequester.go 100.00% <ø> (ø)
dataRetriever/resolvers/baseResolver.go 85.71% <ø> (-3.18%) :arrow_down:
dataRetriever/resolvers/headerResolver.go 90.47% <ø> (-3.41%) :arrow_down:
... and 87 more

... and 33 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Mar 14 '23 08:03 codecov-commenter