mx-chain-go
mx-chain-go copied to clipboard
Gas cost for multi ESDT/NFT transfer
Description of the reasoning behind the pull request
- There was a backward compatibility issue caused by the reversed calling order of the
GasScheduleChangeandEpochConfirmedmethods
Proposed Changes
- add a new gas schedule with the missing setting
- removed the code related to flags from the
GasScheduleChangeas that will raise issues
Testing procedure
- standard internal testnet
- a specific test that proves the gas cost is now changed
- import-db testing
Codecov Report
Base: 70.71% // Head: 70.71% // Increases project coverage by +0.00% :tada:
Coverage data is based on head (
4097fc8) compared to base (62976b5). Patch has no changes to coverable lines.
:exclamation: Current head 4097fc8 differs from pull request most recent head 8c03bf1. Consider uploading reports for the commit 8c03bf1 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## rc/v1.4.0 #4609 +/- ##
==========================================
Coverage 70.71% 70.71%
==========================================
Files 623 623
Lines 83059 83056 -3
==========================================
- Hits 58733 58732 -1
+ Misses 19919 19918 -1
+ Partials 4407 4406 -1
| Impacted Files | Coverage Δ | |
|---|---|---|
| process/smartContract/process.go | 65.89% <ø> (-0.07%) |
:arrow_down: |
| common/pidQueue.go | 96.66% <0.00%> (+3.33%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.