mx-chain-go icon indicating copy to clipboard operation
mx-chain-go copied to clipboard

Fix missing storage resolver for validator info

Open sstanculeanu opened this issue 3 years ago • 1 comments

Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)

  • import DB fails due to missing resolver on validatorInfo topic

Proposed Changes

  • added a storage resolver for validatorInfo topic

Testing procedure

  • import db + standard system test

sstanculeanu avatar Oct 07 '22 14:10 sstanculeanu

Codecov Report

Base: 70.72% // Head: 70.72% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (5b6b60e) compared to base (c44546e). Patch coverage: 75.75% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.4.0    #4566      +/-   ##
=============================================
- Coverage      70.72%   70.72%   -0.01%     
=============================================
  Files            631      631              
  Lines          83901    83927      +26     
=============================================
+ Hits           59339    59357      +18     
- Misses         20121    20125       +4     
- Partials        4441     4445       +4     
Impacted Files Coverage Δ
...esolversContainer/metaResolversContainerFactory.go 73.19% <33.33%> (-0.63%) :arrow_down:
...solversContainer/shardResolversContainerFactory.go 73.33% <33.33%> (-0.82%) :arrow_down:
...esolversContainer/baseResolversContainerFactory.go 78.08% <77.77%> (-0.05%) :arrow_down:
...etriever/dataPool/currentEpochValidatorInfoPool.go 100.00% <100.00%> (ø)
dataRetriever/storageResolvers/sliceResolver.go 94.02% <100.00%> (+0.18%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Oct 13 '22 09:10 codecov-commenter