mx-api-service
mx-api-service copied to clipboard
add fees collector address labelling
Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)
- there was no label for fees collector address
Proposed Changes
- add label to fees collector address
How to test
-
accounts/erd1qqqqqqqqqqqqqpgqur83hqn9j4y6v93m09nn2q0yazuhk2rvpr9sarz5yj->assetsattribute should be defined
Codecov Report
Base: 66.98% // Head: 66.64% // Decreases project coverage by -0.33% :warning:
Coverage data is based on head (
3a55d46) compared to base (6bcf526). Patch coverage: 31.57% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## development #894 +/- ##
===============================================
- Coverage 66.98% 66.64% -0.34%
===============================================
Files 501 502 +1
Lines 12718 12737 +19
Branches 1303 1305 +2
===============================================
- Hits 8519 8489 -30
- Misses 3052 3100 +48
- Partials 1147 1148 +1
| Flag | Coverage Δ | |
|---|---|---|
| integrationtests | 66.64% <31.57%> (-0.34%) |
:arrow_down: |
| unittests | 28.51% <100.00%> (+0.30%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/common/assets/assets.service.ts | 24.19% <0.00%> (-0.40%) |
:arrow_down: |
| src/endpoints/mex/mex.settings.service.ts | 65.15% <10.00%> (-9.85%) |
:arrow_down: |
| src/endpoints/mex/entities/mex.fee.collector.ts | 66.66% <66.66%> (ø) |
|
| src/utils/cache.info.ts | 82.71% <100.00%> (+0.21%) |
:arrow_up: |
| src/common/locked-asset/locked-asset.service.ts | 32.55% <0.00%> (-45.35%) |
:arrow_down: |
| src/common/entities/unlock-schedule.ts | 62.50% <0.00%> (-37.50%) |
:arrow_down: |
| ...ing/transaction.action.stake.recognizer.service.ts | 56.92% <0.00%> (-10.77%) |
:arrow_down: |
| ...ognizers/mex/mex.wrap.action.recognizer.service.ts | 78.57% <0.00%> (-7.15%) |
:arrow_down: |
| src/utils/token.helpers.ts | 64.58% <0.00%> (-4.17%) |
:arrow_down: |
| src/endpoints/nodes/node.service.ts | 50.36% <0.00%> (-0.73%) |
:arrow_down: |
| ... and 6 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I think you can even have a much bigger ttl; there is only one address and it doesn`t change