mtasa-resources icon indicating copy to clipboard operation
mtasa-resources copied to clipboard

Admin chat has no message string size limit

Open ricksterhd123 opened this issue 4 years ago • 2 comments

Which resource(s) have this problem?

admin Describe the bug

There's no limit to how much text can be put into each message. This can cause lag as a consequence to other admins, potentially crashing their MTA clients depending on how much text you put. Who knows, this could potentialy even crash the server if triggerServerEvent isn't non-blocking.

To Reproduce

Open admin panel, go to admin chat. This won't work on the /a command because the chatbox is limited as it should be! Copy and paste as much text as possible into admin chat and submit the message. Now each message sent after will cause freeze lag to other admins.

Expected behavior

You should not even be able to send that much text.

Screenshots

Version

Ver: 1.5.9-9.21035.0

Additional context

I found this out because I was the troll who did it

ricksterhd123 avatar Nov 28 '21 03:11 ricksterhd123

Does this still need to be fixed?

iPollo avatar Apr 10 '22 23:04 iPollo

Yes, feel free to fix it

ricksterhd123 avatar Apr 11 '22 01:04 ricksterhd123