multiarch
Travis build passing although tests failed
While hacking on #7 I've noticed that even though tests fail (because I messed up the packages on the box on my branch) the overall test passes. Please see the log for this job.
I just did the following test:
$ docker run -it --rm multiarch/crossbuild:dev false; echo $?
1
$ docker run -it --rm multiarch/crossbuild:dev true; echo $?
0
The exit code seems to be correctly forwarded to the parent program, so maybe it comes from something else
Did you do further investigations?
@moul I gave up after a while, because it seemed nearly impossible to support #7.
However I've looked into this a bit back then and I remember something about not being able to get tests defined in a Makefile fail properly if one them fails or something along these lines. Not sure anymore.
I've taken a look on the Makefile in the repo just now. The test target contains multiple test steps. I think the test should be executed a big ass <cmd> && <cmd> for them to fail early. Don't take my word for it though.