material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[material-ui] Deprecate `components` and `componentsProps` props

Open DiegoAndai opened this issue 1 year ago • 8 comments

Part of #40417

Description

Deprecate components and componentsProps props, which are planned for removal in v7.

  • These are deprecated in favor of the slot pattern: slots and slotProps
  • If the slots or slotProps props do not exist:
    • They must be implemented in the same PR in which the deprecation is added
    • They should have the same type as the deprecated prop
  • The PR introducing the deprecation must also add:

Example PR

  • https://github.com/mui/material-ui/pull/40777

Contributing

Feel free to take any components that still need to be done or in progress. Please mention this issue in your PR so we can link it in the description and keep it up to date.

Components to migrate

Search keywords: deprecation components componentsProps material-ui

DiegoAndai avatar Feb 26 '24 19:02 DiegoAndai

Hello, I'd like to take on Backdrop.

aacevski avatar Apr 25 '24 19:04 aacevski

Hey @aacevski, assigned! Feel free to let me know if you need any help.

DiegoAndai avatar Apr 25 '24 19:04 DiegoAndai

Hello I'd like to take InputBase component

ChronicusUA avatar May 01 '24 15:05 ChronicusUA

After I added deprecated comment to InputBase the 3 other input components (Input, FilledInput and OutlinedInput) are automatically updated. Seems like we need to prepare 1 PR to update the all 4. Are ok with that or you prefer to prepare 4 PRs for each of them?

ChronicusUA avatar May 01 '24 16:05 ChronicusUA

Hello I'd like to take Tooltip component

ChronicusUA avatar May 03 '24 09:05 ChronicusUA

I will take Popper as well

ChronicusUA avatar May 03 '24 13:05 ChronicusUA

@ChronicusUA id suggest you hold off creating more PR's until your current PRs are reviewed and merged. As it will be difficult for maintainers to manage and review multiple PRs

sai6855 avatar May 03 '24 16:05 sai6855

Hey @ChronicusUA, sorry for not replying earlier. Thanks for working on these. I'll review the PRs now. As @sai6855 suggested, let's work on the current ones before moving on to other components 🙌🏼

DiegoAndai avatar May 03 '24 18:05 DiegoAndai

This issue has been completed! 🎉

Thanks to everyone who contributed, you've helped Material UI become a more consistent library 😊

DiegoAndai avatar Jun 03 '24 14:06 DiegoAndai