material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

Upgrading @types/react-is in @mui/utils

Open NTARelix opened this issue 2 years ago • 1 comments

Aligns with used versions of react and react-is

I hope this resolves https://github.com/mui/material-ui/issues/37068 for me and those affected by that bug, but I wasn't able to successfully test these changes locally.

NTARelix avatar May 04 '23 12:05 NTARelix

Netlify deploy preview

https://deploy-preview-37163--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by :no_entry_sign: dangerJS against 2b3c1650842463a01a19f6975ebe4fce09e6ae09

mui-bot avatar May 04 '23 12:05 mui-bot

+1 for getting this merged as the current state is causing issues

jd-carroll avatar May 04 '23 20:05 jd-carroll

Nice change - would also like to see this issue fixed. Is it possible to go a step further and move the @types/react-is dependency to devDependencies so its not part of the prod dependencies?

derekcicerone avatar May 10 '23 02:05 derekcicerone

+1 for this fix. It will unblock my react 18 migration.

Barlow1 avatar May 11 '23 18:05 Barlow1

While this issue is not merged, we can force the dependency resolution in our package.json. This works with Yarn, I believe NPM uses overrides instead of resolutions.

{
  ...
  "dependencies": {
    ...
  }
  "resolutions": {
    "@types/react-is": "18.2.0"
  }
}

marmelo avatar May 15 '23 09:05 marmelo

We updated the @types/react-is version to 18.2.0 in https://github.com/mui/material-ui/pull/37098. Thanks for the PR.

ZeeshanTamboli avatar May 16 '23 11:05 ZeeshanTamboli