mui
[ChipDelete][joy] Add onDelete prop to ChipDelete
Closes: https://github.com/mui/material-ui/issues/35188
This PR adds onDelete prop to ChipDelete component, onDelete fires when user clicks on component or presses Backspace or enter.
- [x] I have followed (at least) the PR section of the contributing guide.
| Messages | |
|---|---|
| :book: | Netlify deploy preview: https://deploy-preview-35412--material-ui.netlify.app/ |
@mui/joy: parsed: +0.07% , gzip: +0.14%
Generated by :no_entry_sign: dangerJS against 0e7dc3b36aacd86e00802e87a8fb3091989c5dc7
@ZeeshanTamboli updated code as described, but ci/circleci: checkout test is failing. i'm not able to fix it, can you check it once
@ZeeshanTamboli updated changes also added onDelete prop description in docs. preview: https://deploy-preview-35412--material-ui.netlify.app/joy-ui/react-chip/#delete-button
but test-types test is failing not sure why, it is asking to run yarn docs:typescript:formatted but when i ran yarn docs:typescript:formatted DeletableChip.tsx.preview file is got deleted.
but test-types test is failing not sure why, it is asking to run yarn docs:typescript:formatted but when i ran yarn docs:typescript:formatted DeletableChip.tsx.preview file is got deleted.
Then I would suggest to remove onDelete code from the demo. Just the text is enough.
