material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[FocusTrap] Convert focus trap to typescript

Open trizotti opened this issue 3 years ago • 4 comments

closes #34722

trizotti avatar Nov 04 '22 16:11 trizotti

Messages
:book: Netlify deploy preview: https://deploy-preview-35005--material-ui.netlify.app/

Details of bundle changes

Generated by :no_entry_sign: dangerJS against ceed9bdc16e3adc46896b73dae4b2fd6da7d0b86

mui-bot avatar Nov 04 '22 16:11 mui-bot

Thanks for working on this. Could you please also convert the test file to TS?

As for the test_static failing, changing the JSDoc of isEnabled in FocusTrap.types.ts to:

@default function defaultIsEnabled(): boolean {
  return true;
}

should help.

michaldudak avatar Nov 15 '22 11:11 michaldudak

@michaldudak , I just finished with the test file and all the checks are passing now.

trizotti avatar Nov 30 '22 13:11 trizotti

No problem, @michaldudak ... Thanks for the review. I added the suggested changes.

trizotti avatar Dec 15 '22 12:12 trizotti