material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[Typography] Fix `styleOverrides`, `variants`, and remaining colors

Open emillaine opened this issue 3 years ago • 4 comments

Fixes #34290. Fixes #29564.

TODO:

  • Fix extra generated CSS rule color: textPrimary.

emillaine avatar Sep 23 '22 12:09 emillaine

Details of bundle changes

@material-ui/core: parsed: +0.04% , gzip: +0.09%

Generated by :no_entry_sign: dangerJS against d3284d84063db25da1d19f0fd2b698e2bf0ea01f

mui-bot avatar Sep 23 '22 12:09 mui-bot

The CI yarn proptypes check complains about missing color prop, but that seems wrong since this PR didn't add a color prop.

emillaine avatar Oct 21 '22 11:10 emillaine

Any updates on this?

madroneropaulo avatar Dec 12 '22 02:12 madroneropaulo

Nope. The CI test fails for some reason I don't understand. On top of that, my team is working on a major version update to our MUI-based library, which allows us to fix the problem that prompted https://github.com/mui/material-ui/issues/34290 by modifying the palette, removing the need for styleOverrides or other workarounds.

So this PR is currently not prioritized for us. Feel free to pick it up though :)

emillaine avatar Dec 16 '22 15:12 emillaine

Guys, any news here?

Londeren avatar Mar 01 '24 17:03 Londeren