MIDI.js icon indicating copy to clipboard operation
MIDI.js copied to clipboard

Fixed issue with skipping first note, progress counter not starting until 2nd note played, and added end of song callback

Open silverhawk184 opened this issue 8 years ago • 4 comments

silverhawk184 avatar Jan 09 '18 03:01 silverhawk184

Fixed another bug!

silverhawk184 avatar Jan 29 '18 03:01 silverhawk184

Hey @silverhawk184 ! I was trying to use your fixed branch but it is not working. I tried running the gruntfile and it contains outdated paths (polyfill instead of shim). Even when changing the paths and adding missing files, the build doesn't play any sound. It would be nice to have a version that installs like npm install midi.js to just require the module. I've been waiting for this fix for a long time and I got exited for a minute. I wish I had the time to understand the library to make the updates myself. I hope you are able to find a fix. Thanks

xrochoa avatar Feb 14 '18 07:02 xrochoa

Hi ,@silverhawk184 I replaced your player.js to the original one , there is still a looping bug when playing the midi file

qk44077907 avatar Jan 03 '19 09:01 qk44077907

@silverhawk184 sorry, I downloaded to worry version, but the bug skiping the first chord still exist, eventually,to all guys who met this bug: I copied the module in the author's personal project https://galactic.ink/piano/min/app.js (search the keywords Player),it works well.

qk44077907 avatar Jan 03 '19 14:01 qk44077907