UIKitPresentationModifier icon indicating copy to clipboard operation
UIKitPresentationModifier copied to clipboard

Idea to remove swizzling

Open malhal opened this issue 3 years ago • 1 comments

Just thought I'd share an idea that if you used UIViewControllerRepresentable instead of UIViewRepresentable you could handle disappearing without having to swizzle and you wouldn't need to search for nearest VC either. Similar to MyViewController in this code I posted to Stackoverflow, before I found your library (which I found via this blog btw)

I think Apple call theirs PresentationHostingController.

malhal avatar Sep 01 '22 23:09 malhal

Hey @malhal! Thank you for the tip.

I haven't been able to support this as much as I would like - there are some missing features I would love to get done here...

Meanwhile, if you ever get this implementation done without swizzling, I would be super happy to look into your PR and merge this!

mtzaquia avatar Oct 19 '22 13:10 mtzaquia