mtgred
Update terminology to "core damage"
With the release of the Midnight Sun expansion, NISEI replaced "brain damage" terminology for "core damage".
Watch-out-fors
- Replays
- How data is stored in the database
Tasks
- [x] Update player-facing strings
- [ ] Update internal engine usages
Just in case you are wondering how to say "core damage" in Chinese, it's "核心伤害".
When changing Core Damage via the control panel, the text log still says "The Runner sets brain damage to n (+1).
Changing historical replays is not possible, in the same way that fixing a bug and having it apply to a past replay is not possible. Replays do not play the game, they are a list of gamestates (including the message log).
I think this is probably as good as it's going to get. The only usages of brain damage in the message log will be explicitly on old ffg cards, and making those discordant from the printed text you see is not desireable. Internal functions will be wrong for half the card pool regardless, so I believe them staying as they are is the most effective situation, and if somebody gets offended reading through the code they could just as easily do so reading through our code history.