MSYS2-packages icon indicating copy to clipboard operation
MSYS2-packages copied to clipboard

probably needs some looking into (binutils libdep problem)

Open revelator opened this issue 2 years ago • 3 comments

Description / Steps to reproduce the issue

as was discovered by ray donnelly the use of zstd in some gnu software like gdb was wrong putting libzstd in LDFLAGS internally while it should have been in LIBS. this is also the case with the version of binutils we use for MSys2 and breaks building the msys2 runtime if binutils is built after zstd is installed. i guess the reason you have not encountered this is that the ci only pulls in the dependencies listed in the PKGBUILD and zstd is not listed there so you newer get to see this error. If however you rebuild binutils yourself after zstd is installed things get messy and the build of the msys2 runtime fails with undefined references to zstd symbols in libbfd.a. grepping for those symbols also tell you that libbfd.a contains no zstd symbols but it tries to use them regardless.

i added --with-zstd=no to the binutils configure line in the PKGBUILD and that fixes things for the time being, but zstd compression would be nice to have at some point so unless newer binutils allready have this fixed it should be looked at.

Expected behavior

linking with zstd compression.

Actual behavior

zstd symbols are undefined.

Verification

  • [X] I have verified that my MSYS2 is up-to-date before submitting the report (see https://www.msys2.org/docs/updating/)

Windows Version

MSYS_NT-10.0-19044

Are you willing to submit a PR?

No response

revelator avatar Jun 28 '23 19:06 revelator

it is libdep causing headaches again... for some reason the removal of it was removed from the PKGBUILD script in the latest pull, i copied it of the older version and now it works again. pretty strange though that it blames zstd ??.

revelator avatar Jun 30 '23 00:06 revelator

more descriptive issue name would be appreciated

ewancg avatar Aug 30 '23 03:08 ewancg

changed the description though the latest binutils package seems to have this fixed again. small problem with dlfcn-win32 with one package when linking to bfd it tries to use the shared version of libdl causing undefined symbols in the package because it expects the static library.

revelator avatar Aug 30 '23 14:08 revelator