msgpack-c icon indicating copy to clipboard operation
msgpack-c copied to clipboard

Support std::byte* where only char* is currently supported

Open drrlvn opened this issue 8 years ago • 1 comments

For example sbuffer::write() should accept const std::byte * in addition to const char *.

drrlvn avatar Nov 16 '17 10:11 drrlvn

The core of msgpack-c depends on char. For example, https://github.com/msgpack/msgpack-c/blob/master/include/msgpack/v2/parse.hpp#L240

One way to support std::byte is replace xxx with basic_xxx<CharType> all part of msgpack-c. And provide typedef basic_xxx<char> xxx;. Then user can use basic_xxx<std::byte>. It's very big change. I don't think that replace is practical approach.

redboltz avatar Feb 01 '18 12:02 redboltz