Moritz Schauer

Results 309 comments of Moritz Schauer

What is the current practice of this dichotomy? I don’t trust the docs very much, I assume it’s a mixture between the eltype of the samples and other notions of...

For the meantime: https://github.com/mschauer/GaussianDistributions.jl/blob/8be87a4ccba1b2fb143c9005c38b0e63db53b17a/src/GaussianDistributions.jl#L149

Please be careful with operator spacing. It's a mess in the package right now but adding spaces everywhere around `*` and `/` does not reflect Julia Base conventions.

The manual on mathematical operations has it. > By convention, we tend to space operators more tightly if they get applied before other nearby operators. For instance, we would generally...

* I think `α` is an algorithm-argument. The [GES algorithm](https://mschauer.github.io/CausalInference.jl/latest/library/#GES-1) isn't based on tests for example. * I would like a high level interface to support graphs with named vertices....

1.) Yes, `data` needs to be given to `AssociationTest` but it would be the responsibility of `infer_graph` to create this object when calling the PC algorithm with data set `data`...

Are there any tests for edge cases/ULP in the c version we do not do ourselves?

Then we should also add a test for these