CausalInference.jl icon indicating copy to clipboard operation
CausalInference.jl copied to clipboard

WIP: independence tests for categorical variables

Open schnirz opened this issue 7 years ago • 8 comments

implemented permutation-based independence tests for categorical variables based on mutual information and conditional mutual information

open questions:

  • can type information be used more elegantly/efficiently?
  • is the conditional mutual information test implemented correctly? do we need more tests to be sure?
  • are there more efficient entropy estimators that we should implement?

schnirz avatar Dec 09 '18 13:12 schnirz

Codecov Report

Merging #11 into master will increase coverage by 0.95%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   83.99%   84.95%   +0.95%     
==========================================
  Files           7        7              
  Lines         606      638      +32     
==========================================
+ Hits          509      542      +33     
+ Misses         97       96       -1
Impacted Files Coverage Δ
src/pc.jl 89.18% <100%> (+0.79%) :arrow_up:
src/klentropy.jl 89.21% <100%> (+3.31%) :arrow_up:
src/skeleton.jl 89.55% <100%> (+1.62%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f354ca8...b79fa8e. Read the comment docs.

codecov-io avatar Dec 09 '18 14:12 codecov-io

Coverage Status

Coverage increased (+1.0%) to 84.953% when pulling b79fa8e79fd710ee627518252dbb5e5e27781e5b on categorical_tests into f354ca8ce9052293023f7ccefda299bf946dd977 on master.

coveralls avatar Dec 09 '18 14:12 coveralls

Do you think you can make this work without my input? Please merge once you think this is fine.

mschauer avatar Apr 08 '19 11:04 mschauer

Sure, no problem

schnirz avatar Apr 21 '19 10:04 schnirz

@schnirz Is this "okay enough" for me to just merge?

mschauer avatar Aug 14 '19 15:08 mschauer

@mschauer I finally have some time this month to do more work on this, will let you know once I have some sensible ready.

schnirz avatar Oct 07 '19 14:10 schnirz

This is great news. There has been also some interest for this package in the last weeks, so this would be a good time.

mschauer avatar Oct 07 '19 14:10 mschauer

Yearly reminder ;-)

mschauer avatar Oct 10 '20 21:10 mschauer