🐛Flash not working when recording video

[nica0012]

What's happening?

After upgrading from v2 to v3, flash seems to not work anymore while recording a video.

Is anybody else running into this?

Reproduceable Code

(example app)

Relevant log output

n/a

Camera Device

n/a

Device

iPhone 13 Pro Max

VisionCamera Version

3.6.4

Can you reproduce this issue in the VisionCamera Example app?

I didn't try (⚠️ your issue might get ignored & closed if you don't try this)

Additional information

• [ ] I am using Expo
• [ ] I have enabled Frame Processors (react-native-worklets-core)
• [X] I have read the Troubleshooting Guide
• [X] I agree to follow this project's Code of Conduct
• [X] I searched for similar issues in this repository and found none.

[nica0012]

@mrousavy Downgrading to 3.3.1 resolves this along with audio for video. Maybe the issue is related.

[prasan2421]

I have same problem, downgrading to 3.3.1 didn't help either. 😕

[nica0012]

@mrousavy I upgraded to 3.6.6 to give this a try, now when recording the flash starts for about a second or two, then turns off. I noticed in the version notes there was some bug fixes on the flash, but this might be lingering still.

[mrousavy]

Interesting - does audio work flawlessly now though? I should've fixed audio in https://github.com/mrousavy/react-native-vision-camera/pull/2144

[mrousavy]

Might be that we need to delay this: https://github.com/mrousavy/react-native-vision-camera/blob/3dd56c3ba26e5f95fcea4871657b2ef0e7bcb3d8/package/ios/Core/CameraSession.swift#L164-L168

...to make torch work on initial mount, as reported by @metrix-hu in https://github.com/mrousavy/react-native-vision-camera/issues/2050.

That it's not working when recording is a bit weird though, I'll try to fix that.

As a workaround, you can just enable torch={true} when starting your recording, and setting it back to false when stopping on the JS side.

[nica0012]

Interesting - does audio work flawlessly now though? I should've fixed audio in #2144

Audio works great 👍

[nica0012]

Might be that we need to delay this:

https://github.com/mrousavy/react-native-vision-camera/blob/3dd56c3ba26e5f95fcea4871657b2ef0e7bcb3d8/package/ios/Core/CameraSession.swift#L164-L168

...to make torch work on initial mount, as reported by @metrix-hu in #2050.

That it's not working when recording is a bit weird though, I'll try to fix that.

As a workaround, you can just enable torch={true} when starting your recording, and setting it back to false when stopping on the JS side.

Sounds great I'll give this workaround a go for now, thank you 💯

[mrousavy]

Hey I think I fixed this in a recent change! Flash in video is now handled on JS side (as torch)