react-native-multithreading icon indicating copy to clipboard operation
react-native-multithreading copied to clipboard
verified publisher icon mrousavy

docs(SETUP.md): correct other JSI libs example

Open david-gettins opened this issue 4 years ago • 2 comments

  • [x] Correct the import path for the JSI module in the example
  • [x] ~~Add MMKV into the example - I feel most people would be using these together and could use the example.~~

Also, I had to follow this suggested fix but replace mmkv with multithreading.

david-gettins avatar Sep 29 '21 11:09 david-gettins

Hey! Thanks for the PR, but can you remove MMKV out of there? I think the MMKV docs explain how to set it up correctly anyways.

mrousavy avatar Sep 30 '21 07:09 mrousavy

I've removed the MMKV part of the example and the RN 0.65 comment. As far as I am aware auto-linking JSI libs still hasn't made it in.

david-gettins avatar Oct 04 '21 15:10 david-gettins