node-dogstatsd icon indicating copy to clipboard operation
node-dogstatsd copied to clipboard

Added Event Support

Open JamesWiresmith opened this issue 10 years ago • 5 comments

I require event support the library so this pull request includes the changes.

  • Added event function for generating events.
  • Refactored the tag generation into a single function that can be used by metrics and events.
  • Included testing for the above changes. (using mocha)

JamesWiresmith avatar May 28 '15 09:05 JamesWiresmith

Any plans for this to get merged in? If it's waiting for a resolution of conflicts, I can provide a new PR with that included if that's needed. I'm going to be working off of my own fork with this, so just hoping this can get merged in at some point.

bdeitte avatar Aug 04 '15 15:08 bdeitte

(I've also updated things so that it does not do a console.log anywhere and events.tags can be used with a null events.options)

bdeitte avatar Aug 04 '15 16:08 bdeitte

@JamesMc86 thanks for great patch. @bdeitte would you please PR after resolving conflict?

I hesitated to keep this project alive because this is technically obsoleted since sivy/node-statsd get to support tag and histogram which were only differences b/w sivy/node-statsd and node-dogstatsd. But.. anyway :)

joybro avatar Aug 05 '15 07:08 joybro

Ah, I had no idea that node-statsd had added support for this. Which is amusing, because I use that library as well for some graphite work.

I'm actually having trouble seeing this work. I should have that fixed up in the next day or two and will submit a new PR with that work in it.

bdeitte avatar Aug 05 '15 20:08 bdeitte

See https://github.com/brightcove/hot-shots for a place where this has all been pulled in and is in use

bdeitte avatar May 24 '16 13:05 bdeitte