mpv-build icon indicating copy to clipboard operation
mpv-build copied to clipboard

libdav1d

Open truexfan81 opened this issue 1 year ago • 6 comments

please add --enable-libdav1d to scripts/ffmpeg-config

thank you

truexfan81 avatar Nov 11 '24 01:11 truexfan81

You can easily do this yourself as described in the README.

sfan5 avatar Nov 11 '24 08:11 sfan5

You can easily do this yourself as described in the README.

Yes i did that on my current build environment, the problem is remembering to do it in the future. I was not even aware it was required until yesterday when i gave my build of mpv a youtube link that was in AV1 and it wouldn't play it. To prevent a repeat of that for myself and others i sent a pull request with it added to the script.

truexfan81 avatar Nov 11 '24 23:11 truexfan81

I think a good solution would be to enable dav1d by default if it's installed like scripts/ffmpeg-config does for either gnutls or openssl.

sfan5 avatar Nov 26 '24 09:11 sfan5

I think a good solution would be to enable dav1d by default if it's installed like scripts/ffmpeg-config does for either gnutls or openssl.

It's possible, but in this case where do we stop?

kasper93 avatar Nov 26 '24 10:11 kasper93

The general principle of mpv-build seems to be that the user should enable what he needs, hence my first reply. But AV1 support is arguably a core feature to expect from a video player, so it makes sense to auto-detect.

sfan5 avatar Nov 26 '24 10:11 sfan5

But AV1 support is arguably a core feature to expect from a video player, so it makes sense to auto-detect.

Indeed. I would expect ffmpeg to actually provide it by default (autodetect), but it has to be explicitly enabled.

kasper93 avatar Nov 26 '24 10:11 kasper93