git-spell-check icon indicating copy to clipboard operation
git-spell-check copied to clipboard

Add commit msg hook

Open roygrssmn opened this issue 6 years ago • 4 comments

I have used this project as a base for my script.
I have added a commit-msg that is using the aspell dictionary and same logic as in the original pre-commit script.

Also in this MR:

  • bash warnings fix
  • update readme
  • fix to work on aspell on linux, using the "./" reference
  • change from SIGNALS to EXIT

roygrssmn avatar Oct 05 '19 13:10 roygrssmn

Yikes, I totally forgot about this PR, sorry!

@roygrssmn What's the point of a second file that is mostly identical to pre-commit but has a different name? You could probably just check the name of the file when its executed to determine which actions to take (if any differ between pre-commit and commit-msg).

Thanks for the contribution!

mprpic avatar Jan 14 '21 13:01 mprpic

Hey @mprpic, you mean that .commit-msg call .pre-commit script?

roygrssmn avatar Jun 12 '21 16:06 roygrssmn

Hey @mprpic, you mean that .commit-msg call .pre-commit script?

I'm saying if you'd like to use that script as a commit-msg hook as well you could instead just modify the instructions to create a symlink from pre-commit to commit-msg instead of duplicating the entire file with just a different name.

mprpic avatar Jun 14 '21 14:06 mprpic

you could instead just modify the instructions to create a symlink from pre-commit to commit-msg instead of duplicating the entire file with just a different name.

Yeah... It'll also mean maintaining 2 different files that do mostly the same thing

NOTE: I didn't check the diffs to know exactly what's changed or what's happening, this comment is only based on the repository's owner's comment

alvindera97 avatar Jul 01 '24 09:07 alvindera97