Marshall Perrin

Results 262 comments of Marshall Perrin

**Comment by [josePhoenix](https://github.com/josePhoenix)** _Tuesday Nov 22, 2016 at 13:49 GMT_ ---- By the way: thanks for the high-quality bug report, @douglase!

**Comment by [josePhoenix](https://github.com/josePhoenix)** _Tuesday Nov 22, 2016 at 13:58 GMT_ ---- The relevant section of `OpticalSystem.input_wavefront` is: ```python # somewhat complicated logic here for historical reasons. # if we have...

**Comment by [josePhoenix](https://github.com/josePhoenix)** _Tuesday Nov 22, 2016 at 14:00 GMT_ ---- Here's a workaround: ```python import poppy zernike_optic = poppy.ZernikeWFE(radius=r, coefficients=[0, 0, 0.000001, 0]) r = 0.0254 osys = poppy.OpticalSystem()...

**Comment by [douglase](https://github.com/douglase)** _Friday Nov 25, 2016 at 18:47 GMT_ ---- Thanks for clearing that up, I didn't see that `_accept_wavefront_or_meters` wrapper was creating a wavefront. It seems like that...

**Comment by [josePhoenix](https://github.com/josePhoenix)** _Friday Nov 25, 2016 at 19:40 GMT_ ---- Agreed, this is not the least astonishing API. The decorator there should be used consistently as well; a lot...

Here's some code I wrote last year in the course of `gpipsfs` development. Basic Kolmogorov phase screen, though limited in its ability to properly model turbulence at larger angular scales...

This code is now available in poppy-ized form in the `kolmogorov` branch. _warning_, not yet ready for prime time. Something's scaled incorrectly somewhere so I'm getting WFE in excess of...

See #249 which is a much better version of this.

Some mention somewhere in the Sphinx docs perhaps? Not sure. I don't have a specific fix in mind. But demonstrably we should probably do _something_ since Scott asked for this...

(More generally @douglase, it would be great if you could chat with @sdwill sometime. What you're both doing for WFIRST and LUVOIR modeling respectively has a lot of similarities, I...