Mark Pentler
Mark Pentler
Hi @AntonTru3 ! Any chance you can take the latest codebase and try submitting these again? May also want to check your indents etc for consistency. Thanks!
@antontru3 are you still around? Shall we get this fixed up? Happy to pull it when it’s all sorted.
Tabs everywhere instead of spaces. All we need is a rebase and a quick check of your additions and it's good to go.
I’ve fixed all of the issues with the additions, but there’s the conflicts to sort too. I’ll save that for another day.
Hello @yedhink ! Can you do two things? Can you take the latest codebase and submit this again? Also, can you check some facts to see that they work independently...
@yedhink are you still here? I want to take these facts because they are very good, but significant work has been done since you submitted this PR. Are you able...
Oh man, this is so close to being ready, but there are some conflict markers left in. One final edit? :)
Yeah, I'm sorry buddy, still a few things. One issue I've just noticed is that the facts need to work independently of each other. So each fact must have the...
Partly addressed in #356
My notes for later: -check the ALL_FACTS tuple -check the readme list -check the regex list -check the facts list -are they all in alphabetical order