web-ext icon indicating copy to clipboard operation
web-ext copied to clipboard

fix: ctrl + C does nothing when using firefox-android without auto-reload or during activity start

Open luskaner opened this issue 3 years ago • 2 comments

Ctrl + C does nothing when using firefox-android in either of these two cases:

  • [x] Automatic reloading is disabled.
  • [x] Waiting to launch the activity on Android. For example: this occurs indefinitely when my device when it is locked.

Fixes #1699

luskaner avatar Oct 10 '22 13:10 luskaner

Codecov Report

Base: 99.58% // Head: 99.59% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (7dd22e7) compared to base (ca73b70). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2523   +/-   ##
=======================================
  Coverage   99.58%   99.59%           
=======================================
  Files          32       32           
  Lines        1697     1720   +23     
=======================================
+ Hits         1690     1713   +23     
  Misses          7        7           
Impacted Files Coverage Δ
src/extension-runners/firefox-android.js 100.00% <100.00%> (ø)
src/util/adb.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 10 '22 13:10 codecov[bot]

I think the PR is ready for review (I changed the title for the step npm run github-pr-title-lint of the ci/circleci: build-nosejs-current pipeline but does not update)

luskaner avatar Oct 10 '22 18:10 luskaner