probe-scraper icon indicating copy to clipboard operation
probe-scraper copied to clipboard

Remove dupe-metric hack

Open badboy opened this issue 1 year ago • 2 comments

I added a hack to get firefox-desktop to work properly again: https://github.com/mozilla/probe-scraper/blob/5717fce6ddcf5ce103cd7e47414c348547cf8651/probe_scraper/glean_checks.py#L19-L25

We should find a way that this is not necessary. It shouldn't. The metric is moved from the app to the library.

badboy avatar Feb 20 '24 11:02 badboy

This looks like it could be a similar issue that caused https://github.com/mozilla/probe-scraper/issues/711 so I'll append to this one. In that case, the metrics file was removed from mozillavpn_backend_cirrus and nimbus-cirrus was added as a dependency so in that case removing the metrics worked

BenWu avatar Mar 14 '24 20:03 BenWu

This list got longer now (#849) -- this hopefully can go when https://bugzilla.mozilla.org/show_bug.cgi?id=1940030 lands in m-c

badboy avatar Jan 07 '25 10:01 badboy