experimenter icon indicating copy to clipboard operation
experimenter copied to clipboard

Increase the exhaustiveness of audience targeting in integration tests

Open jaredlockhart opened this issue 3 years ago • 7 comments

We recently added integration tests using the SDK to validate jexl expressions. Now we can test each of the 'advanced' targeting options for each desktop and mobile client. However we should probably also test each of the built in audience fields as well, so we should add additional tests where we set each field on the audience page individually and validate the expression in the respective client.

┆Issue is synchronized with this Jira Task

jaredlockhart avatar Jun 08 '22 20:06 jaredlockhart

➤ Benjamin Forehand Jr. commented:

Christopher Knowles did you get assigned to this by mistake?

data-sync-user avatar Jun 13 '22 21:06 data-sync-user

➤ Christopher Knowles commented:

Yes, I’m not aware of ever visiting this - but history shows that I assigned myself. I’m assuming some bizarre mis-key event. Apologies for the noise.

data-sync-user avatar Jun 13 '22 21:06 data-sync-user

➤ Benjamin Forehand Jr. commented:

Jared Kerim since you are removing graphQL should I wait on this?

data-sync-user avatar Jun 14 '22 19:06 data-sync-user

➤ Jared Kerim commented:

Oh interesting point. We should be able to do this on desktop where it uses the UI now regardless of whether the API is GraphQL or REST. And yeah we can update the SDK integration tests to REST after it lands and do this for them then.

data-sync-user avatar Jun 14 '22 19:06 data-sync-user

➤ Benjamin Forehand Jr. commented:

Going to start working on this

data-sync-user avatar Aug 25 '22 15:08 data-sync-user

➤ Benjamin Forehand Jr. commented:

A bit held up with some other more urgent things but this is still on my TODO.

data-sync-user avatar Sep 08 '22 16:09 data-sync-user

➤ Benjamin Forehand Jr. commented:

Going to turn this into an epic and divide the desktop and mobile work

data-sync-user avatar Sep 13 '22 20:09 data-sync-user