experimenter icon indicating copy to clipboard operation
experimenter copied to clipboard

Experimenter not redirecting on missing trailing slash

Open mikewilli opened this issue 1 year ago • 7 comments

The Experimenter API is erroneously responding with "Please login using OpenID Connect".

jlockhart Edit: Experimenter should redirect if a trailing slash is missing to a url including a trailing slash but for some reason since we updated to Django 5 it's no longer doing that on prod, but I am unable to reproduce this locally.

┆Issue is synchronized with this Jira Task

mikewilli avatar Feb 27 '24 20:02 mikewilli

I'm unable to reproduce this either in my browser with an authenticated or unauthenticated session or from using requests from a command line. Are you still able to reproduce this @mikewilli ?

jaredlockhart avatar Feb 27 '24 21:02 jaredlockhart

Nope, looks like it fixed itself!

mikewilli avatar Feb 27 '24 22:02 mikewilli

Ok, this is happening again now so I'm going to reopen. Can you take a look again when you have a chance?

mikewilli avatar Feb 28 '24 14:02 mikewilli

Ah, so what's happening here is ommitting the trailing slash / will not redirect but rather just halt on the openidc error. Let's get the redirect working again. This was probably disrupted as part of the django 5 update.

jaredlockhart avatar Feb 28 '24 19:02 jaredlockhart

Also this would have been clearer if a URL had been included in the original bug.

jaredlockhart avatar Feb 28 '24 19:02 jaredlockhart

Oh whoops, I sent it in the original chat message but forgot it here, sorry!

mikewilli avatar Feb 28 '24 20:02 mikewilli

I can't seem to recreate this locally. No matter what combination of DEBUG=False/True, nginx.conf X-Forwarded-For, make up/up_prod, I can't make my local NOT redirect correctly. So I can't figure out why it's not redirecting in prod.

jaredlockhart avatar Feb 29 '24 19:02 jaredlockhart